-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scroll bottom - jump to last message (WPB-4987) (WPB-3973) #2343
Conversation
…p-to-last-msg-gitfix
APKs built during tests are available here. Scroll down to Artifacts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice 🧑🍳
Just one question: do we have 2 scaffolds in the composable tree? I think we can achieve similar functionality with adding box with some ime padding for this button? 🤔
Build 1413 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⬇️
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We don't have a way in the app to quickly navigate to the bottom of the messages list, aka. jump to last message.
Solutions
Implement it by using Scaffold FAB embedded into messages list component, taking at the same time advantage that MessagesList component, passed down is a composable, so I was able to have it for free for Disabled message composer as well.
Using the outer scaffold was not an option after many tries, because it also considers the attachment options menu, making it almost impossible to customize the position dynamically.
Testing
Test Coverage (Optional)
How to Test
Scroll so the last message is hidden, then the button should appear.
Attachments (Optional)
###Conversations with several messages and without scrollable content
Screen.Recording.2023-10-18.at.15.13.12.mov
###Read only Conversations
Screen.Recording.2023-10-18.at.15.36.19.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.